Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @shopify/eslint-plugin from 45.0.0 to 46.0.0 in /vscode #2379

Closed
wants to merge 1 commit into from
Closed

Bump @shopify/eslint-plugin from 45.0.0 to 46.0.0 in /vscode #2379

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 29, 2024 •
edited
Loading

Bumps @shopify/eslint-plugin from 45.0.0 to 46.0.0.

Release notes

Sourced from @​shopify/eslint-plugin's releases.

@​shopify/eslint-plugin@​46.0.0

Major Changes

Changelog

Sourced from @​shopify/eslint-plugin's changelog.

46.0.0

Major Changes

Commits
  • a7dd1c2 Version Packages
  • 7380da9 Move import/parsers configuration into esnext
  • e636f05 Update README to specify eslint flat config
  • 10bac7d Flatten enable-all-configs into sole use in all/eslint.config.js fixture
  • 224f4ed Update tests to use eslint.config.js format
  • c495b79 extend import/typescript config
  • 9858cb0 fix: extend prettier config
  • 8981d6b Match files at arbitrary depths
  • 248ab1e Separate out plugin.js to avoid circular import
  • 3294b3d Put config extends at correct level
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner July 29, 2024 02:39
@dependabot dependabot bot added the dependencies dependencies label Jul 29, 2024
@dependabot dependabot bot requested a review from andyw8 July 29, 2024 02:39
@dependabot dependabot bot added the javascript Pull requests that update Javascript code label Jul 29, 2024
@dependabot dependabot bot requested review from vinistock and a team July 29, 2024 02:39
@andyw8
Copy link
Contributor

andyw8 commented Jul 31, 2024

I used the tool to generate the new config file, still getting an error though:

vscode dependabot/npm_and_yarn/vscode/shopify/eslint-plugin-46.0.0 % yarn run eslint '**/*.ts' && prettier '**/*.{json,md,yaml,yml}' --check
yarn run v1.22.22
$ /Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/.bin/eslint '**/*.ts'

Oops! Something went wrong! :(

ESLint: 9.8.0

TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'Object'
    |     property 'configs' -> object with constructor 'Object'
    |     property 'flat/recommended' -> object with constructor 'Object'
    |     property 'plugins' -> object with constructor 'Object'
    --- property 'promise' closes the circle
Referenced from: 
    at JSON.stringify (<anonymous>)
    at file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/shared/config-validator.js:296:45
    at Array.map (<anonymous>)
    at ConfigValidator.formatErrors (file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/shared/config-validator.js:287:23)
    at ConfigValidator.validateConfigSchema (file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/shared/config-validator.js:317:84)
    at ConfigArrayFactory._normalizeConfigData (file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/config-array-factory.js:673:19)
    at ConfigArrayFactory._loadExtendedPluginConfig (file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/config-array-factory.js:893:25)
    at ConfigArrayFactory._loadExtends (file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/config-array-factory.js:808:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (file:///Users/andyw8/src/github.com/Shopify/ruby-lsp/vscode/node_modules/@eslint/eslintrc/lib/config-array-factory.js:749:25)
    at _normalizeObjectConfigDataBody.next (<anonymous>)

@andyw8 andyw8 force-pushed the dependabot/npm_and_yarn/vscode/shopify/eslint-plugin-46.0.0 branch from 777b555 to 1088748 Compare July 31, 2024 15:44
@andyw8 andyw8 mentioned this pull request Jul 31, 2024
Closed
@egiurleo
Copy link
Contributor

egiurleo commented Aug 5, 2024

@dependabot recreate

@dependabot
Bump @shopify/eslint-plugin from 45.0.0 to 46.0.0 in /vscode
59eded6 
Bumps [@shopify/eslint-plugin](https://github.com/Shopify/web-configs/tree/HEAD/packages/eslint-plugin) from 45.0.0 to 46.0.0.
- [Release notes](https://github.com/Shopify/web-configs/releases)
- [Changelog](https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/Shopify/web-configs/commits/@shopify/[email protected]/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@shopify/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/vscode/shopify/eslint-plugin-46.0.0 branch from 1088748 to 59eded6 Compare August 5, 2024 20:10
@egiurleo
Copy link
Contributor

egiurleo commented Aug 7, 2024

Closing in favor of #2416

@egiurleo egiurleo closed this Aug 7, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 7, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@egiurleo egiurleo deleted the dependabot/npm_and_yarn/vscode/shopify/eslint-plugin-46.0.0 branch August 7, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 Awaiting requested review from andyw8 andyw8 is a code owner automatically assigned from Shopify/ruby-dx

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
dependencies dependencies javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @egiurleo